set event result, and add warnings to velocity plugin messaging docs #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also includes more specific diagrams for each case, fixed identifier checking, rather than by identity, and instanceof Player player style cast.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
zlataovce
requested changes
Sep 4, 2024
Co-authored-by: Matouš Kučera <[email protected]>
456dev
force-pushed
the
improve/velocity-pm
branch
from
99258df
to
f21de89
Compare
zlataovce
reviewed
Sep 22, 2024
zlataovce
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as well as the warnings and updated example code, it also includes